getgrav / getgrav/grav-plugin-simplesearch

Should simplesearch be compatible with IE11/older versions of Edge?

Open
#159 1 comment 0 reactions 0 assignees View on GitHub
Dominant language
PHP
Stars
46
Forks
55
Avg merge
5h 44m
Merged PRs (30d)
1

Description

Hi,

We've run into an issue when using the simplesearch plugin on IE11 and older versions of Edge: these browsers don't support foreach on a NodeList (as employed [here](https://github.com/getgrav/grav-plugin-simplesearch/blob/1e381a79912987693fca3f551a18d3a0f7b229f6/js/simplesearch.js#L8)). Moreover, it seems that this means that all of our js doesn't load on these browsers if we choose to pipeline the js.

Are these browsers meant to be supported by this plugin (or is there another strategy we should be employing to address the lack of support)?

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.