getgrav / getgrav/grav-plugin-simplesearch

Problem with "Events" Plugin installed

Open
#131 0 comments 0 reactions 0 assignees View on GitHub
Dominant language
PHP
Stars
46
Forks
55
Avg merge
5h 44m
Merged PRs (30d)
1

Description

Hi all,

i just noticed using simplesearch and the "Events" Plugin side by side is not working out.

I get the following error:
`
user/plugins/simplesearch/simplesearch.php
345: $taxonomy_values = implode('|',$values);
implode(): Invalid arguments passed
`

I did not have much type to further investigate but the events plugin is adding its own "event"/"events" taxonomy to pages. So maybe simplesearch should further investigate the "$values" or maybe its better to rewrite the "Events" Plugin to be more gravcms conform?

Any help or infos are greatly appreciate!

Greets, Chris

Contributor guide

No contributing guide indexed for this repository

Research direction

Start at user/plugins/simplesearch/simplesearch.php line 345 and reproduce the error with SimpleSearch and the Events plugin installed together. Inspect how the Events plugin adds its event/events taxonomy and how SimpleSearch supplies $values to implode(). Done means the plugins coexist without the reported invalid-arguments error.

Written by the indexing model from the issue text.

Assessment

Tech stack
php
Domain
search
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
25/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.