getgrav / getgrav/grav-plugin-shortcode-core

Dash in parameter name breaks `shortcodes` Twig filter

Open
#125 2 comments 0 reactions 0 assignees View on GitHub
Dominant language
PHP
Stars
47
Forks
17
PR merge metrics
No merged PRs in 30d

Description

I'm trying out `shortcodes-core` v5.2.0 and it appears that having a parameter with a name containing a dash completely breaks it: the handler function is simply not called in this case.

Steps to reproduce:

1. Install `grav-admin-v1.7.46`.
2. Edit `themes/quark/templates/partials/footer.html.twig` and add `{{ '[fa=cog my-param /]'|shortcodes|raw }}` somewhere inside the `

` tag.

The output in HTML will be `[fa=cog my-param /]`, i.e. the shortcode's literal without any transformatin (not a suprise as logging shows that its handler is not called at all).

If you change the short code to just `{{ '[fa=cog myparam /]'|shortcodes|raw }}` (notice no dash), all works — the handler is called and the icon appears.

Note that there is no such a problem when the same shortcode (i.e. with the dash in the parameter name) is used inside a `.md` file — all works correctly in this case and the icon properly is generated as well. So the problem only appears with the `shortcodes` filter (with or without `raw`).

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.