getgrav / getgrav/grav-plugin-maintenance

Allow maintenance page to be non-routable

Open
#33 2 comments 0 reactions 0 assignees View on GitHub
Dominant language
PHP
Stars
17
Forks
16
PR merge metrics
No merged PRs in 30d

Description

I expected that it would be possible to specify a page with `routable: false` in its frontmatter, but this causes a 404 to show up instead.

The error plugin **does** allow this so I quickly glanced the code there. I am not familiar with the plugin API so I'll just link to the differences in page handling between the plugins in case this saves someone else looking that up.

- The error plugin [sets the page on the event object](https://github.com/getgrav/grav-plugin-error/blob/develop/error.php#L63),
- whereas this plugin [sets it on the plugin instance](https://github.com/getgrav/grav-plugin-maintenance/blob/develop/maintenance.php#L95-L100) (and enables two more hooks).

Contributor guide

No contributing guide indexed for this repository

Research direction

Compare the page handling in maintenance.php around lines 95-100 with the error plugin's error.php around line 63, focusing on how each plugin exposes the page to Grav. Trace the maintenance plugin's hooks and verify the behavior with a page using routable: false; done means the maintenance page renders instead of returning a 404.

Written by the indexing model from the issue text.

Assessment

Tech stack
php
Domain
backend
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
38/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.