getgrav / getgrav/grav-plugin-maintenance

The login ACL isn't respected during maintenance

Open
#32 1 comment 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
PHP
Stars
17
Forks
16
PR merge metrics
No merged PRs in 30d

Description

When setting some pages to be hidden when the user isn't logued :

access:
    site.login: true
login:
    visibility_requires_access: true

and activating the maintenance, the page wich is displayed has the header and footer showing as usual, but the page isn't hidden anymore in the menu.

Confirmation

Disabling the maintenance plugin solve the problem, and the pages is hidden back.

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Reproduce the issue in the Grav maintenance plugin using the shown access and login configuration, then compare menu visibility with maintenance enabled and disabled. Trace how maintenance mode handles pages requiring login access. Done means pages hidden from unauthenticated users remain hidden in the menu while maintenance is active.

Written by the indexing model from the issue text.

Assessment

Tech stack
php
Domain
authorization, backend
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
42/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.