getgrav / getgrav/grav-plugin-form

Checkbox has extra padding because of invisible, duplicated label

Open
#441 2 comments 0 reactions 0 assignees View on GitHub
Dominant language
PHP
Stars
64
Forks
80
Avg merge
10h 13m
Merged PRs (30d)
9

Description

The current checkbox implementation has an invisible label which causes the form to add an ugly extra margin

![grafik](https://user-images.githubusercontent.com/6888294/94424052-dfb10600-0189-11eb-8879-695212a9bf58.png)
![grafik](https://user-images.githubusercontent.com/6888294/94424107-f8212080-0189-11eb-98d4-c73f15995626.png)

The "real" label is placed right next to the input field, and thatswhy the normal label is not needed. In the code the label is cleared (empty block), but the div around will still be there.

I will upload a PR shortly that should be linked by github itself.

Contributor guide

No contributing guide indexed for this repository

Research direction

Locate the checkbox implementation and inspect how its invisible label and surrounding div are rendered. Remove the empty label wrapper responsible for the extra margin, then verify that the real label remains adjacent to the input and the checkbox form no longer has the unwanted padding.

Written by the indexing model from the issue text.

Assessment

Tech stack
php
Domain
frontend
Issue type
Bug
Difficulty
2/5
Estimated time
1-3 hours
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
45/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.