getgrav / getgrav/grav-plugin-admin

Hostname is missing from pages in YAML linter

Open
#2,405 0 comments 0 reactions 0 assignees View on GitHub
Dominant language
PHP
Stars
377
Forks
225
Avg merge
11h 51m
Merged PRs (30d)
4

Description

![image](https://github.com/getgrav/grav-plugin-admin/assets/2323565/a0481a51-8d06-4c9f-a93e-bb653ca94567)

The following page link directs to `http://admin/pages/sistemos_administravimas/duk/duk_007/mode:expert`, i.e. the hostname is missing. At first I wanted to fix it and make inline how base_url is set in Security Scan template, because it works there, but I saw that it was actually changed in https://github.com/getgrav/grav-plugin-admin/commit/56d97e5833261e333ca378a9ef4dbb0b7110985b .

I will leave this to the people who understand better what is going on.

Contributor guide

Open the contributing guide

Research direction

Start by locating the YAML linter code that generates the reported page link and compare its base_url handling with the Security Scan template. Review commit 56d97e5833261e333ca378a9ef4dbb0b7110985b; the fix is complete when the generated link includes the hostname instead of starting at /admin.

Written by the indexing model from the issue text.

Assessment

Tech stack
php
Domain
backend
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
45/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.