getgrav / getgrav/grav-plugin-admin

admin.yaml pagemedia resize_quality - best value is 0.99 not 1

Open
#2,393 0 comments 0 reactions 0 assignees View on GitHub
Dominant language
PHP
Stars
377
Forks
225
Avg merge
11h 51m
Merged PRs (30d)
4

Description

**Description**

.jpg / .jpeg images are not being resized and subsequently displayed in Admin Panel -> Page -> Page Media section,
if [admin.yaml](https://github.com/getgrav/grav-plugin-admin/blob/develop/admin.yaml) contains the (erroneous) following line:

```
pagemedia:
resize_quality: 1
```

The correct highest possible value is `0.99`.


**Cause** (_apart from my own stupidity_)

- The documentation is unclear here.


**Proposed solution**

update [all language strings](https://github.com/getgrav/grav-plugin-admin/blob/8b089b54f535bb04656fac882ccc40b75e80adb0/languages/en.yaml#L1123) and [documentation](https://learn.getgrav.org/17/admin-panel/dashboard/configuration-system#media) (if any)

from
` RESIZE_QUALITY_HELP: "The quality to use when resizing an image. Between 0 and 1 value."`
to
` RESIZE_QUALITY_HELP: "The quality to use when resizing an image. Between 0.01 and 0.99 value."`


For reference:
- [blueprints.yaml]( https://github.com/getgrav/grav-plugin-admin/blob/8b089b54f535bb04656fac882ccc40b75e80adb0/blueprints.yaml#L772)

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.