getgrav / getgrav/grav-plugin-admin
Not including a leading slash in Administrator Path causes navigation issues
- Dominant language
- PHP
- Stars
- 377
- Forks
- 225
- Avg merge
- 11h 51m
- Merged PRs (30d)
- 4
Description
Version: Admin Panel v1.10.38
If a user leaves out a leading slash in the Administrator Path setting, this can allow the navigation to start to act up as the link generation seems to assume that it should use a relative directory path based on the current URL
Example:
If a user goes to modify the admin panel plugin's settings from the web ui:
User clicks on Plugins and gets the list of plugins, the url is [sitename]/[adminpath]/plugins
User clicks on Admin Panel plugin in the list, url becomes [sitename]/[adminpath]/[adminpath]/plugins/admin

If user then clicks on Plugins in the side nav again to try to return to the list, url becomes [sitename]/[adminpath]/[adminpath]/plugins/[adminpath]/plugins

Recommendations:
- Modify url generation to base path based on grav root instead of current url
OR
- Modify admin panel to have sanity check to prompt user to have leading forward slash in box
Contributor guide
Assessment
This issue has not been assessed yet.