getgrav / getgrav/grav-plugin-admin
Event 'onAdminRegisterPermissions' replaced with oddly named 'PermissionsRegisterEvent::class' event
- Dominant language
- PHP
- Stars
- 377
- Forks
- 225
- Avg merge
- 11h 51m
- Merged PRs (30d)
- 4
Description
Just curious, why has an oddly event name `PermissionsRegisterEvent::class` been chosen when deprecating event `onAdminRegisterPermissions`?
It feels as if code for Grav v1.7.0-rc.4 and Admin v1.10.0-rc.4 hasn't been properly finished...
Wouldn't a name like `onAdminPermissionsInitialized` be more in line with longstanding event names like:
- onProblemsInitialized
- onPluginsInitialized
- onThemeInitialized
- onBackupsInitialized
- onSchedulerInitialized
- onAssetsInitialized
- onTwigInitialized
- onBuildPagesInitialized
- onPagesInitialized
- onPageInitialized
- onMarkdownInitialized
Would it be possible to replace event name `PermissionsRegisterEvent::class` with a better one?
Contributor guide
Assessment
This issue has not been assessed yet.