getgrav / getgrav/grav-plugin-admin

Blueprint default override header.visible not respected by admin page creation

Open
#1,853 2 comments 0 reactions 1 assignee Claimed by @mahagr View on GitHub
bug
Dominant language
PHP
Stars
377
Forks
225
Avg merge
11h 51m
Merged PRs (30d)
4

Description

In an inherited theme, I make an 'item.yaml' blueprint that extends the parent (Quark, in this case) theme's 'item.yaml':

```yaml
extends@: item

form:
fields:
tabs:
fields:
advanced:
fields:
overrides:
fields:
header.visible:
toggleable: false
default: 0
```

In 1.6.x, when using the Item template to create a page 'New Item' in Admin with the setup outlined above, clicking 'Save' automatically creates the following code in the new page's header:

```
---
title: 'New Item'
visible: false
---
```

However, in 1.7.0-rc.7, doing so omits the `visible: false` line, even though the admin GUI correctly shows 'Disabled' as selected next to the 'Visible' item. To have the `visible: false` line saved to the page header requires manually clicking on the 'Disabled' button in the GUI and then saving the page.

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.