getgrav / getgrav/grav-plugin-admin

List field collapsible variable for button position

Open
#1,747 0 comments 0 reactions 0 assignees View on GitHub
Dominant language
PHP
Stars
377
Forks
225
Avg merge
11h 51m
Merged PRs (30d)
4

Description

There is a setting we can choose to set the position of the list button to bottom, top or both that is called controls. But inside of this condition there is another variable that check if the list can is collapsible or not.

But in the corresponding file forms/fields/list/list.html.twig the line that check for this parameter is not well placed :

`{% set collapsible = field.fields|length > 1 and (field.collapsible is not defined or field.collapsible) %}
`

It is on line 68 and is first used on line 49. Thus on line 49 it is always null so the button can't appear on top and the parameter is then useless.

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.