getgrav / getgrav/grav-plugin-admin

User not informed of failed validation on non-active tab on page admin form

Open
#1,342 2 comments 0 reactions 0 assignees View on GitHub
enhancement
Dominant language
PHP
Stars
377
Forks
225
Avg merge
11h 51m
Merged PRs (30d)
4

Description

**Problem:** Failed validation on a _non-active_ tab in a page form in admin will (correctly) cause the page not to save, but there is no warning of this.

e.g. in the example below, if I enter a **!** in the folder name and this fails validation (which incidentally it won't do unless you override the blueprint and set the pattern), switch to a different tab, the page won't save, but I won't be explictly told this and I'd have to switch back to the `Advanced` tab to see the highlighted failed validation.
screen shot 2018-02-16 at 18 53 54

I would expect 1) a warning e.g. "Folder Name failed validation" and probably 2) the first tab with an error to be activated.

Cheers

Nick

Contributor guide

Open the contributing guide

Research direction

No file or test is named in the issue. Reproduce the admin page form validation with an invalid value on a non-active tab, then verify that completion includes a warning and activation of the first tab containing an error.

Written by the indexing model from the issue text.

Assessment

Tech stack
php
Domain
frontend
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
38/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.