getappmap / getappmap/appmap-python
Allow creation of Config instances
Nobody has claimed this yet.
- Dominant language
- Python
- Stars
- 104
- Forks
- 17
- PR merge metrics
- No merged PRs in 30d
Description
Not sure about making it a singleton -- singleton configuration tends to come back biting me later. (I can imagine, for example, when trying to drive, from a python script, a more complicated project with parts needing different settings.) Would it be a good idea to instead have a default instance but allow constructing and using others? Could also make it easier to test if it becomes more complicated.
Originally posted by @dividedmind in https://github.com/applandinc/appmap-python/pull/31#discussion_r575681654
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
This issue is an old design discussion and names no files, tests, or entry points. Start by locating the current Config implementation and its default-instance usage, then determine whether independently constructed configurations can coexist without breaking existing callers. Done means the design is settled, multiple settings can be used safely, and the behavior is covered by tests.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- python
- Domain
- tooling
- Issue type
- Feature
- Difficulty
- 5/5
- Estimated time
- Over a week
- Activity status
- Stale
- Clarity
- Needs clarification
- Newbie friendliness
- 25/100