getappmap / getappmap/appmap-python

urllib3 v2 breaks detection of http_client_requests in apps that use the "requests" package

Open
#239 0 comments 0 reactions 1 assignee View on GitHub

@apotterri is already working on this.

Since May 9, 2023.

appmap-python enhancement
Dominant language
Python
Stars
104
Forks
17
PR merge metrics
No merged PRs in 30d

Description

The latest version of the widely-used requests package has changed to depend on v2 of urllib3. This breaks capturing of http_client_requests for apps that use it.

Pinning to v1 of urllib3 (as suggested in the requests doc) fixes this, but appmap-python should support both versions of urllib3.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.