getappmap / getappmap/appmap-python

django integration bypassed when config is missing

Open
#127 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

bug
Dominant language
Python
Stars
104
Forks
17
PR merge metrics
No merged PRs in 30d

Description

When APPMAP=true, but the config file is missing, the django middleware forwards all requests to the app. This means that requests for /_appmap/record will fail, without giving a clear indication of the problem.

It would be better if the requests for /_appmap/record failed with an error (e.g. 500), to help the user understand the problem

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Locate the Django middleware handling APPMAP and the /_appmap/record request, then reproduce the behavior with APPMAP=true and no config file. Done means requests to /_appmap/record return a clear error instead of being forwarded to the application.

Written by the indexing model from the issue text.

Assessment

Tech stack
django, python
Domain
backend
Issue type
Bug
Difficulty
2/5
Estimated time
1-3 hours
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
45/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.