getappmap / getappmap/appmap-python

Capture native code calls

Open
#126 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
Python
Stars
104
Forks
17
PR merge metrics
No merged PRs in 30d

Description

Native code functions and methods have types.BuiltinFunctionType or types.BuiltinMethodType; they're currently explicitly skipped for hooking at https://github.com/applandinc/appmap-python/blob/bdaeab2eacad1e8478addd4afbf815d4ef91aa33/appmap/_implementation/recording.py#L160 and so can't be captured. One difficulty of handling these is that they don't have ordinary descriptors and wrapt, which is the library we're using to wrap code, doesn't handle this case.

Note to actually capture the call parameters #124 would need to be done, too.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Read appmap/_implementation/recording.py at the linked skip logic and inspect how wrapt is used to wrap ordinary code. Determine how BuiltinFunctionType and BuiltinMethodType calls can be hooked, then ensure their parameters are captured as required by issue #124.

Written by the indexing model from the issue text.

Assessment

Tech stack
python
Domain
devtools
Issue type
Feature
Difficulty
5/5
Estimated time
Over a week
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.