getappmap / getappmap/appmap-node
Wrong parent in some async flows
Nobody has claimed this yet.
- Dominant language
- TypeScript
- Stars
- 13
- Forks
- 6
- Avg merge
- 18h 23m
- Merged PRs (30d)
- 8
Description
In some async scenarios, the event parent is not set correctly. Consider for example https://github.com/lukaszbulak/NestJS-TypeORM-Example and this AppMap resulting from npx appmap-node npm start dev & sleep 10 ; curl http://localhost:3000/boards:
As you can see, the SQL request is not under getBoards (as it should be) but is a separate root. Note this seems intermittent; here's another AppMap of an identical request, with no changes (not even a server restart):
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by reproducing the NestJS-TypeORM-Example scenario with npx appmap-node npm start dev & sleep 10; curl http://localhost:3000/boards and compare the resulting AppMaps. Investigate how async event parents are assigned around the getBoards request and its SQL request. Done means repeated identical runs consistently place the SQL request under getBoards rather than as a separate root.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- typescript
- Domain
- observability
- Issue type
- Bug
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Needs clarification
- Newbie friendliness
- 30/100