getappmap / getappmap/appmap-js
Pass -W parameter to yarn 1 installer
Nobody has claimed this yet.
- Dominant language
- TypeScript
- Stars
- 53
- Forks
- 18
- Avg merge
- 3d 18h
- Merged PRs (30d)
- 8
Description
When installing with yarn 1, pass -W parameter.
One of the errors of installing the agent with yarn 1 was
error Running this command will add the dependency to the workspace root rather than the workspace itself, which might not be what you want - if you really meant it, make it explicit by running this command again with the -W flag (or --ignore-workspace-root-check).
Although part of this error is that yarn packages weren't detected as subprojects, another part is that yarn 1 needs to be passed the parameter -W to install in a root workspace.
See https://github.com/getappmap/appmap-js/pull/936#pullrequestreview-1248646007 for more details.
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Inspect the Yarn 1 installation path and the changes discussed in pull request 936. Confirm where the root-workspace install command is assembled, then verify that Yarn 1 receives -W and that the agent installation completes without the workspace-root warning.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- typescript
- Domain
- build-system
- Issue type
- Bug
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 45/100