getappmap / getappmap/appmap-js

External services in appmap are missing events

Open
#956 3 comments 0 reactions 1 assignee View on GitHub

@ahtrotta is already working on this.

Since Feb 8, 2023.

bug sequence diagrams
Dominant language
TypeScript
Stars
53
Forks
18
Avg merge
3d 18h
Merged PRs (30d)
8

Description

This is based off of one of our tests in packages/components. Before, when the external service was selected, there was an associated event that appeared in the details panel:

Image

Now, that event is not present:

Image

This has been causing a test to fail, but it has been ignored because test failures in packages/components weren't causing builds to fail (fixed here).

This test broke in this PR. You can see the last Chromatic build that worked correctly here.

Link to last good Chromatic build, and link to first broken Chromatic build. Merge commit Travis build of breaking PR.

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.