getappmap / getappmap/appmap-js

packages/components/.storybook/run.js doesn't work in CI

Open
#618 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
TypeScript
Stars
53
Forks
18
Avg merge
3d 18h
Merged PRs (30d)
8

Description

While working on #607 I noticed there were errors in .storybook/run.js that were implicitly skipped in Node 14.
I've added an explicit silencing for the build to pass in Node 18, but this still needs to be fixed.
See for example https://app.travis-ci.com/github/applandinc/appmap-js/jobs/573053743#L1231 :

➤ YN0000: [@appland/components]: (node:7001) UnhandledPromiseRejectionWarning: Error: Command failed: git diff origin/main --name-only
➤ YN0000: [@appland/components]: fatal: ambiguous argument 'origin/main': unknown revision or path not in the working tree.
➤ YN0000: [@appland/components]: Use '--' to separate paths from revisions, like this:
➤ YN0000: [@appland/components]: 'git <command> [<revision>...] -- [<file>...]'
➤ YN0000: [@appland/components]: 
➤ YN0000: [@appland/components]:     at ChildProcess.exithandler (child_process.js:383:12)
➤ YN0000: [@appland/components]:     at ChildProcess.emit (events.js:400:28)
➤ YN0000: [@appland/components]:     at maybeClose (internal/child_process.js:1088:16)
➤ YN0000: [@appland/components]:     at Socket.<anonymous> (internal/child_process.js:446:11)
➤ YN0000: [@appland/components]:     at Socket.emit (events.js:400:28)
➤ YN0000: [@appland/components]:     at Pipe.<anonymous> (net.js:686:12)
➤ YN0000: [@appland/components]: (Use `node --trace-warnings ...` to show where the warning was created)
➤ YN0000: [@appland/components]: (node:7001) UnhandledPromiseRejectionWarning: Unhandled promise rejection. This error originated either by throwing inside of an async function without a catch block, or by rejecting a promise which was not handled with .catch(). To terminate the node process on unhandled promise rejection, use the CLI flag `--unhandled-rejections=strict` (see https://nodejs.org/api/cli.html#cli_unhandled_rejections_mode). (rejection id: 1)
➤ YN0000: [@appland/components]: (node:7001) [DEP0018] DeprecationWarning: Unhandled promise rejections are deprecated. In the future, promise rejections that are not handled will terminate the Node.js process with a non-zero exit code.
➤ YN0000: [@appland/components]: Process exited (exit code 0), completed in 6s 668ms

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start with packages/components/.storybook/run.js and inspect the git diff origin/main --name-only call shown in the CI log. Reproduce the Storybook build in CI with Node 18; done means the command no longer produces an unhandled promise rejection or causes the build to fail.

Written by the indexing model from the issue text.

Assessment

Tech stack
git, javascript, node.js, storybook
Domain
ci-cd, tooling
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.