getappmap / getappmap/appmap-js

Install fails in a poetry project when `virtualenvs.create` is `false`

Open
#611 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
TypeScript
Stars
53
Forks
18
Avg merge
3d 18h
Merged PRs (30d)
8

Description

If the user configures poetry with virtualenvs.create = false (e.g. in ~/.config/pypoetry/config.toml), poetry writes a warning to stdout when appmap-agent-init gets run:

root@d6e62d18d48a:/Users/ajp/src/cisco-open/otel-py# poetry run appmap-agent-init
Skipping virtualenv creation, as specified in config file.
{"configuration": {"filename": "appmap.yml", "contents": "name: otel-py\npackages:\n- path: tests\n- path: cisco_telescope\n"}}

This causes installation to fail because we try to parse the contents of stdout JSON.

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start at the appmap-agent-init entry point and reproduce the command in a Poetry project with virtualenvs.create=false. Trace how stdout is captured and parsed; done means Poetry's warning no longer causes the configuration JSON parsing to fail.

Written by the indexing model from the issue text.

Assessment

Tech stack
typescript
Domain
cli
Issue type
Bug
Difficulty
2/5
Estimated time
1-3 hours
Activity status
Stale
Clarity
Clearly specified
Newbie friendliness
45/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.