getappmap / getappmap/appmap-js

Improve error handling in partial AppMap

Open
#552 0 comments 0 reactions 1 assignee View on GitHub

@sashahonchar is already working on this.

Since Feb 21, 2022.

Dominant language
TypeScript
Stars
53
Forks
18
Avg merge
3d 18h
Merged PRs (30d)
8

Description

When limiting root events to HTTP, nothing is displayed in the trace view:
image

Also while root events are limited to HTTP, HelloWorldServer$HelloWorldHandler is missing from the dependency map:
image

Toggling Limit root events to HTTP off displays the desired results in the dependency map:
image

However the HTTP server request is still missing from the trace view:
image

Below is the AppMap described. It's worth noting that two of the three events in the AppMap do not return:

  • http_server_request - no return
  • HelloWorldHandler#handle - no return
  • HelloWorldHandler#sayHello - returns

It's likely that the missing returns here are causing issues. The AppMap client should be able to gracefully handle cases where such data is missing.
hw.appmap.json.txt

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.