getappmap / getappmap/appmap-js
Repository URL format
Nobody has claimed this yet.
- Dominant language
- TypeScript
- Stars
- 53
- Forks
- 18
- Avg merge
- 3d 18h
- Merged PRs (30d)
- 8
Description
Hi guys, if the repository URL is "https://github.com/sasha7/notes-app.git" and we click on the View Source button then "http://https///github.com/sasha7/notes-app/blob/master/controllers/home.controller.js#L2" gets opened. See: appmap
I'm trying the locate were to correct the issue. The appmap spec mentions this for the metadata.git.repository field: "Required repository URL.". Even the example is: "https://github.com/applandinc/appmap". Accordingly, the JS agent is providing the http url. However other agents provide the git form which work fine -- eg: "git@github.com:land-of-apps/sample_app_6th_ed.git" in appmap
Should we update the spec and the JS agent?
Or should we make the viewer support the http format?
Or is the error not related to metadata.git.repository?
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start at the View Source URL construction and compare the JS agent's metadata.git.repository value with the AppMap specification and the cited controllers/home.controller.js link. Determine whether the malformed URL belongs to the agent, specification, or viewer; done means the cited HTTPS repository URL opens the intended source location without breaking the existing git-form URL.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- typescript
- Domain
- devtools
- Issue type
- Bug
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Needs clarification
- Newbie friendliness
- 25/100