getappmap / getappmap/appmap-js

Bug: Installer: validation fails for a Maven project if an old version of appmap agent exists in .m2 cache

Open
#439 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
TypeScript
Stars
53
Forks
18
Avg merge
3d 18h
Merged PRs (30d)
8

Description

Error:

Running command: javac -version
javac 11.0.9
Running command: .\mvnw.cmd -Dplugin=com.appland:appmap-maven-plugin help:describe
Running command: .\mvnw.cmd appmap:print-jar-path
[INFO] Scanning for projects...
[INFO]
[INFO] ------------< org.springframework.samples:spring-petclinic >------------
[INFO] Building petclinic 2.3.1.BUILD-SNAPSHOT
[INFO] --------------------------------[ jar ]---------------------------------
[INFO]
[INFO] --- appmap-maven-plugin:1.2.0:print-jar-path (default-cli) @ spring-petclinic ---
Downloading from spring-snapshots: https://repo.spring.io/snapshot/com/appland/appmap-agent/maven-metadata.xml
Downloading from spring-milestones: https://repo.spring.io/milestone/com/appland/appmap-agent/maven-metadata.xml
java.home=C:\Progra~1\Java\openjdk-11.0.10_9
com.appland:appmap-agent.jar.path=C:\Users\petrd\.m2\repository\com\appland\appmap-agent\1.4.1\appmap-agent-1.4.1.jar
[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
[INFO] Total time:  1.927 s
[INFO] Finished at: 2021-10-27T21:34:06-04:00
[INFO] ------------------------------------------------------------------------
Running command: java -jar C:\Users\petrd\.m2\repository\com\appland\appmap-agent\1.4.1\appmap-agent-1.4.1.jar -d C:/data/github/spring-petclinic init
Init AppMap project configuration in directory: C:/data/github/spring-petclinic
{
    "configuration":{
        "contents":"# This is the AppMap configuration file.\r\n# For full documentation of this file for Java programs, see:\r\n# https://appland.com/docs/reference/appmap-java.html#configuration\r\nname: spring-petclinic\n# Your project contains the directory src/main/java.\r\n# AppMap has auto-detected the following Java packages in this directory:\r\npackages:\r\n- path: org.springframework.samples.petclinic\n",
        "filename":"appmap.yml"
    }
}
Running command: java -jar C:\Users\petrd\.m2\repository\com\appland\appmap-agent\1.4.1\appmap-agent-1.4.1.jar -d C:/data/github/spring-petclinic validate
[INFO] Scanning for projects...
Unmatched argument at index 2: 'validate'
Did you mean: status?
appmap.cli.exception:
Error: An error occurred while running the command: [31mjava -jar C:\Users\petrd\.m2\repository\com\appland\appmap-agent\1.4.1\appmap-agent-1.4.1.jar -d C:/data/github/spring-petclinic validate[39m
The command exited with code [31m2[39m
[31m>  [39mUnmatched argument at index 2: 'validate'
[31m>  [39m
[31m>  [39mDid you mean: status?
   at ChildProcess.<anonymous> (C:\Users\petrd\AppData\Roaming\npm-cache\_npx\16760\node_modules\@appland\appmap\built\src\cmds\agentInstaller\commandRunner.js:93:27)
   at ChildProcess.emit (events.js:315:20)
   at Process.ChildProcess._handle.onexit (internal/child_process.js:277:12)

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Reproduce the installer validation on a Maven project with an older AppMap agent in the .m2 cache, using the commands and output shown in the report. Inspect the installer command runner around built/src/cmds/agentInstaller/commandRunner.js; done means validation no longer invokes an incompatible cached agent and the Maven project completes successfully.

Written by the indexing model from the issue text.

Assessment

Tech stack
java, typescript
Domain
build-system, tooling
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.