getappmap / getappmap/appmap-js

Running web server and test case in a single process results in non-unique finding hashes

Open
#1,455 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

bug scanner
Dominant language
TypeScript
Stars
53
Forks
18
Avg merge
3d 18h
Merged PRs (30d)
8

Description

See the gist here: https://gist.github.com/dustinbyrne/45ba62f12cfa3a4cbc3a42b84dbf1db8

The HTTP request is both issued from and handled within the same process. This adds the test case to the finding stack, causing hash_v2 to report a new finding for each test file where the finding is present.

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start with the linked gist and locate the hash_v2 entry point in the TypeScript code. Reproduce the case where the HTTP request is issued and handled in one process, then compare finding hashes across test files; the fix is complete when the same finding receives a non-unique hash in this setup.

Written by the indexing model from the issue text.

Assessment

Tech stack
typescript
Domain
devtools, testing-qa
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.