getappmap / getappmap/appmap-js

Scanner does not re-scan

Open
#1,331 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

bug
Dominant language
TypeScript
Stars
53
Forks
18
Avg merge
3d 18h
Merged PRs (30d)
8

Description

A recent change to @appland/scanner caused a test in vscode-appland to fail most of the time in CI, which has been causing a lot of build failures (builds fail ~75% of the time):

1 failing
  1) Scanner
       is performed as AppMaps are modified:
     Error: No Diagnostics were created for Microposts_controller_can_get_microposts_as_JSON
  	at waitFor (out/test/waitFor.js:35:23)
  	at async repeatUntil (out/test/waitFor.js:7:9)
  	at async Context.<anonymous> (out/test/integration/scanner/performAsAppMapsAreModified.test.js:55:9)

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start with out/test/integration/scanner/performAsAppMapsAreModified.test.js and the waitFor failure at out/test/waitFor.js:35. Investigate why the scanner does not re-scan modified AppMaps and why diagnostics are missing in CI; done means this test passes reliably instead of failing most of the time.

Written by the indexing model from the issue text.

Assessment

Tech stack
typescript
Domain
testing
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.