getappmap / getappmap/appmap-js

Installer prints a clear error when project-type is required but not provided

Open
#1,277 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

bug
Dominant language
TypeScript
Stars
53
Forks
18
Avg merge
3d 18h
Merged PRs (30d)
8

Description

Without project-type, the installer may exit with code 1

https://github.com/getappmap/appmap-server/actions/runs/5568697170/jobs/10183437134#step:7:30

/home/runner/work/_actions/getappmap/install-action/v1-pre.10/webpack:/install-appmap-action/build/executeCommand.js:65
                reject(new Error(`Command failed with code ${code}`));
^
Error: Command failed with code 1

Related: https://github.com/getappmap/install-action/issues/15

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by reviewing the linked GitHub Actions run and the install-action error location at build/executeCommand.js:65, then read related install-action issue #15 for context. Reproduce the missing project-type case and verify that the installer reports a clear, actionable error instead of only exiting with code 1.

Written by the indexing model from the issue text.

Assessment

Tech stack
github-actions, typescript
Domain
ci-cd, tooling
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
42/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.