getappmap / getappmap/appmap-java
Spark integration doesn't honor appmap.recording.requests
Open
Nobody has claimed this yet.
- Dominant language
- Java
- Stars
- 88
- Forks
- 17
- Avg merge
- 2d 2h
- Merged PRs (30d)
- 1
Description
Using the Waltz project, when running the pre-build jar with the appmap request recording disabled still generates request recordings.
java -javaagent:$HOME/.appmap/lib/java/appmap.jar -cp waltz-web/properties:waltz-local-config/src/main/resources:waltz-web/target/classes:./waltz-web/target/waltz-web-jar-with-dependencies.jar -Dwaltz.port=8080 -Dappmap.recording.requests=false -Dappmap.disableLogFile=true org.finos.waltz.web.Main
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by reproducing the issue with the Waltz pre-build jar and the provided Java agent command, focusing on the Spark integration and the appmap.recording.requests=false setting. Trace how that setting is handled during request recording, then verify that the same command produces no request recordings when recording is disabled.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- java, spark
- Domain
- backend
- Issue type
- Bug
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100