getappmap / getappmap/appmap-java

Normalized paths not present in AppMaps with shallow-recorded spring framework classes

Open
#104 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
Java
Stars
88
Forks
17
Avg merge
2d 2h
Merged PRs (30d)
1

Description

For the same app & appmap.jar, the HTTP server request events are different:

without spring framework events:

            "event": "call",
            "http_server_request": {
                "normalized_path_info": "/owners/:ownerId",
                "path_info": "/owners/2",
                "protocol": "HTTP/1.1",
                "request_method": "GET"
            },

with spring framework events:

            "event": "call",
            "http_server_request": {
                "path_info": "/owners/2",
                "protocol": "HTTP/1.1",
                "request_method": "GET"
            },

appmap.yml:

name: spring-petclinic
# Your project contains the directory src/main/java.
# AppMap has auto-detected the following Java packages in this directory:
packages:
- path: org.springframework.samples.petclinic
- path: org.springframework.web
  shallow: true
  exclude:
    - org.springframework.web.filter.OncePerRequestFilter

FindOwnerDavis.appmap.json.zip
Spring_Find_Owner.appmap.json.zip

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start with the two attached AppMap JSON archives and the appmap.yml package configuration. Compare HTTP server request event generation with and without shallow-recorded Spring classes, focusing on why normalized_path_info is omitted. Done means normalized paths remain present in the affected AppMaps when Spring framework classes are shallow-recorded.

Written by the indexing model from the issue text.

Assessment

Tech stack
java, spring
Domain
api, backend
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
38/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.