getAlby / getAlby/lightning-browser-extension
Fix Lightning Address email regex to support unicode domains
Open
bug
hacktoberfest
- Dominant language
- TypeScript
- Stars
- 585
- Forks
- 228
- Avg merge
- 6d 7h
- Merged PRs (30d)
- 16
Description
Our email regex that we use to check if something is a lightning address does not support unicode domains like (丰.ml)
Can we safely change that: https://github.com/getAlby/lightning-browser-extension/blob/57db3b3a178acc4ad0109c543c970f33787cd410/src/common/lib/lnurl.ts#L13 ?
email regex is hard. maybe we just use: `/\S+@\S+/` ?
Contributor guide
Assessment
This issue has not been assessed yet.