getAlby / getAlby/lightning-browser-extension

[BUG] Shouldn't be possible to derive from master key without first delete current keys

Open
#2,971 0 comments 0 reactions 0 assignees View on GitHub
Dominant language
TypeScript
Stars
585
Forks
228
Avg merge
6d 7h
Merged PRs (30d)
16

Description

### Is there an existing issue for this?

- [X] I have searched the existing issues

### Describe the bug

Shouldn't be possible to derive from master key without first delete current keys

![Captura de tela de 2023-12-28 12-54-40](https://github.com/getAlby/lightning-browser-extension/assets/1178856/9958c2dc-75ee-4000-bdfa-abce6e42412c)

### Screenshots [optional]

_No response_

### Steps To Reproduce

1- Go to Nostr settings that already have a Nostr imported key

### Expected behavior

Only show the button Derive from Master Key when the user Remove the current Keys

### Alby information

Alby: 3.6.0

### Device information

_No response_

### Additional context

_No response_

### Are you working on this?

No

Contributor guide

Open the contributing guide

Research direction

Start in the Nostr settings UI and reproduce the issue with an already imported Nostr key. The change is done when Derive from Master Key is not shown until the current keys are removed; verify that the settings flow still permits removal and derivation.

Written by the indexing model from the issue text.

Assessment

Tech stack
typescript
Domain
frontend
Issue type
Bug
Difficulty
2/5
Estimated time
1-3 hours
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
45/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.