getAlby / getAlby/lightning-browser-extension
Check for protocol and port in allowances
Open
idea
- Dominant language
- TypeScript
- Stars
- 585
- Forks
- 228
- Avg merge
- 6d 7h
- Merged PRs (30d)
- 16
Description
### Feature description
Currently allowances only consider the domain they are being created on regardless of the protocol or port being used.
### Describe the solution
- Include the fully qualified origin for allowances (maybe `origin.domain` could be used here instead of `origin.host`)
- Migrate existing allowances (prefix with https)
- Potentially display a warning on the enable screen when connecting to non-ssl domains (MITM)
### Describe alternatives
_No response_
### Additional context
_No response_
### Are you working on this?
None
Contributor guide
Assessment
This issue has not been assessed yet.