getAlby / getAlby/go

Remove wallet ids and use client pubkeys

Open
#258 1 comment 0 reactions 0 assignees View on GitHub
Dominant language
TypeScript
Stars
57
Forks
21
Avg merge
2h 9m
Merged PRs (30d)
1

Description

Also includes moving to `/:pubkey/settings` etc. routes so we don't do stuff like fetching `selectedWalletId` from the store in each screen.

This would also help in eliminating the case where the same connection string is added multiple times and mainly the instances where wallet ids are decremented by 1 on deleting a wallet, which looks very bad.

Contributor guide

No contributing guide indexed for this repository

Research direction

Start by tracing the app's routes, screens, and the store usage of selectedWalletId. Replace wallet-ID-based navigation with pubkey routes such as /:pubkey/settings, then verify that duplicate connection strings and wallet-ID decrement behavior on deletion are eliminated.

Written by the indexing model from the issue text.

Assessment

Tech stack
typescript
Domain
mobile
Issue type
Refactor
Difficulty
5/5
Estimated time
Over a week
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
30/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.