get-convex / get-convex/convex-agent-plugins
pre-commit-checks.sh hook fails on Windows (beforeShellExecution)
- Dominant language
- Shell
- Stars
- 110
- Forks
- 13
- Avg merge
- 13m
- Merged PRs (30d)
- 3
Description
## Summary
The Cursor plugin's `beforeShellExecution` hook runs `./scripts/pre-commit-checks.sh` on `git commit`, but this does not work reliably on Windows.
## Environment
- OS: Windows 10/11
- Editor: Cursor
- Plugin: Convex Cursor plugin (`hooks.json` → `beforeShellExecution`)
- Hook command: `./scripts/pre-commit-checks.sh`
## Problem
`hooks.json` invokes a Bash script directly:
```json
{
"command": "./scripts/pre-commit-checks.sh",
"matcher": "\\bgit\\s+commit\\b"
}
```
On Windows, Cursor does not appear to execute `.sh` files via a Bash interpreter automatically. The hook fails to run when the agent (or IDE) runs `git commit`.
## Expected behavior
Pre-commit Convex checks should run cross-platform when `git commit` is executed from Cursor on Windows, same as on macOS/Linux.
## Actual behavior
Windows prompts to open the .sh file (or opens it in the configured editor if any).
Contributor guide
Research direction
Start with hooks.json and scripts/pre-commit-checks.sh, then inspect how the Cursor beforeShellExecution hook invokes the script for git commit. Reproduce the failure in Cursor on Windows and verify that the Convex pre-commit checks execute there without breaking the existing macOS/Linux behavior.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- shell
- Domain
- tooling
- Issue type
- Bug
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Activity status
- Active
- Clarity
- Clearly specified
- Newbie friendliness
- 72/100