georust / georust/netcdf

Naming inconsistency File/Variable for putting attribute

Open
#172 0 comments 0 reactions 0 assignees View on GitHub
good first issue
Dominant language
Rust
Stars
105
Forks
29
PR merge metrics
No merged PRs in 30d

Description

For adding a variable we use [`add_attribute`](https://docs.rs/netcdf/latest/netcdf/struct.FileMut.html#method.add_attribute) for `FileMut`, but [`put_attribute`](https://docs.rs/netcdf/latest/netcdf/struct.VariableMut.html#method.put_attribute) for `VariableMut`. This should be `put_attribute` for both.

In addition other namings should be considered to more closely match `netcdf-c`, e.g. `add_type` -> `nc_def_dim`/`def_type`

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.