geopython / geopython/pywps

ComplexOutput data as reference always generates a file named "input.csv", should be "output".

Open
#674 1 comment 0 reactions 0 assignees View on GitHub
Dominant language
Python
Stars
186
Forks
117
Avg merge
11d 20h
Merged PRs (30d)
1

Description

# Description

When returning a ComplexOutput as Reference (output as_reference is True), the filename generated by the server (and used in the built URL) is always "input", eg "input.csv" for a "txt/csv" output, or "input.xml" for an "application/xml" output. This is misleading to users as this is actually the _Output_ file.

After some digging through the sourcecode, I found where that name is set:
https://github.com/geopython/pywps/blob/d0bb9787207e670f4cf8ec5fc3d56abb284226e1/pywps/inout/basic.py#L271-L276

It appears there is no way to set this name on the ComlexOutput object, or on the FileStorage object or on the DataHandler object.

# Environment

- operating system: Ubuntu 22.04
- Python version: 3.8
- PyWPS version: 4.5.2
- source/distribution
- [ ] git clone
- [ ] Debian
- [x] PyPI
- [ ] zip/tar.gz
- [ ] other (please specify):

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.