geopython / geopython/GeoHealthCheck

Make 1.3.0 default WMS version

Open
#455 0 comments 0 reactions 0 assignees View on GitHub
bug
Dominant language
Python
Stars
92
Forks
75
PR merge metrics
No merged PRs in 30d

Description

This issue https://github.com/geopython/GeoHealthCheck/issues/248 and PR https://github.com/geopython/GeoHealthCheck/pull/307 had pretended to change the default WMS version to 1.3.0, but I believe it still needs some improvement, because version 1.1.1 is still hardcoded in some places:

https://github.com/search?q=repo%3Ageopython%2FGeoHealthCheck%201.1.1&type=code

Also, changing from 1.1.1 to 1.3.0 implies some differences, for instance:
- From `SRS` to `CRS`;
- BBOX from `xmin,ymin,xmax,ymax` to `ymin,xmin,ymax,xmax`

I've tried to change locally all default 1.1.1 to 1.3.0, but WMS Drilldown keeps using `version=1.1.1`, and I could not find why.

At this time I think 1.3.0 should be the default for all tests of GHC, and it seems it is not, even after https://github.com/geopython/GeoHealthCheck/pull/307.

**Context (please complete the following information):**
- GeoHealthCheck Version 0.9.0

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.