geonetwork / geonetwork/core-geonetwork

Metadata editor - Editor page indent type doesn't seem to work

Open
#6,879 3 comments 0 reactions 0 assignees View on GitHub
Dominant language
Java
Stars
521
Forks
514
Avg merge
6d 13h
Merged PRs (30d)
19

Description

**Describe the bug**
The setting `Editor page indent type` doesn't seem to work, the metadata editor is always displayed with the colored indent value:

![metadata-editor-indent-setting](https://user-images.githubusercontent.com/1695003/222354341-a98bbebc-57f0-452c-afc9-5d057dfefc24.png)

**To Reproduce**

Steps to reproduce the behavior:

1. Go to Admin console > UI settings and set the value of `Editor page indent type` to `Default, minimal indents`
2. Go to the Editor board and create a new iso19139 metadata.
3. The editor is displayed with the colored indent value:

![metadata-editor-indent](https://user-images.githubusercontent.com/1695003/222354531-60150132-f69b-4ec4-88c1-9876ddc12621.png)

**Expected behavior**
The editor is displayed using the style `Default, minimal indents`.

**Additional context**

This code doesn't seem to have effect:

https://github.com/geonetwork/core-geonetwork/blob/4bfd6cb6aae9887804a2629ef32bbb3d38f32402/web-ui/src/main/resources/catalog/js/edit/EditorController.js#L402-L412

@fxprunayre any idea about this? I would expect `Default, minimal indents` displays the metadata as used to be displayed in GeoNetwork 3.12.x.

Contributor guide

Open the contributing guide

Research direction

Start in web-ui/src/main/resources/catalog/js/edit/EditorController.js at the referenced lines, then reproduce the issue by setting Admin console > UI settings > Editor page indent type to “Default, minimal indents” and creating a new iso19139 metadata record in the Editor board. Done means the editor uses the selected minimal-indent style instead of colored indents.

Written by the indexing model from the issue text.

Assessment

Tech stack
javascript
Domain
frontend
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
45/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.