geonetwork / geonetwork/core-geonetwork

Disclaimer option in settings appears to have no effect

Open
#4,459 3 comments 0 reactions 0 assignees View on GitHub
bug stale
Dominant language
Java
Stars
521
Forks
514
Avg merge
6d 13h
Merged PRs (30d)
19

Description

**Describe the bug**
In GN2 there used to be an option to display a disclaimer (constraints on usage of the data) when downloading an uploaded file. The setting to switch this on is still available in Settings, but doesn't appear to have any effect.

**To Reproduce**
Steps to reproduce the behavior:
1. Go to Admin console / Settings
2. Under download service select 'Use geonetwork disclaimer and constraints service' instead of simple service (set to true and false respectively)
3. Create a new 19139 or 19115-3:2018 metadata record, upload and link a file, add some constraints and publish the record
4. Log out and download the uploaded file
5. The file just downloads - no disclaimer/constraints are displayed

**Expected behavior**
When attempting to download the file a disclaimer is displayed which must be accepted before the file can be downloaded.

**Screenshots**

![image](https://user-images.githubusercontent.com/1860215/75003719-e3c2ca00-54bc-11ea-9f18-ee826a32f288.png)

**Additional context**
tested in master branch

Contributor guide

Open the contributing guide

Research direction

Start in Admin console / Settings by reproducing the download-service behavior with the disclaimer and simple service options, then follow the uploaded-file download flow. Done means the configured disclaimer and constraints are displayed and must be accepted before the file downloads, while the simple service continues to download directly.

Written by the indexing model from the issue text.

Assessment

Tech stack
java
Domain
backend
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.