geocoder-php / geocoder-php/Geocoder
LocationIQ - State AdminLevels do not have their codes set.
Open
Nobody has claimed this yet.
- #1122 by @BrodyT — closed without merging
- Dominant language
- PHP
- Stars
- 4k
- Forks
- 525
- Avg merge
- 8m
- Merged PRs (30d)
- 1
Description
Even after doing a few workarounds to add the parameter "statecode=1" (added to the end of the api key, since withData() doesn't appear to be working), the adminLevels still do not have the code set.
I've traced this back to how the adminLevels are populated on line 121 of the provider, the code is statically set to ''.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start in the LocationIQ provider around line 121, where the issue reports that adminLevel codes are set to an empty string. Review how the statecode=1 parameter is passed and how adminLevels are populated, then verify that returned state admin levels retain their codes.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- php
- Domain
- api
- Issue type
- Bug
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 45/100