gentics / gentics/mesh

Improve Documentation of Authentication Service Plugin API

Open
#857 0 comments 0 reactions 0 assignees View on GitHub
documentation quick win
Dominant language
Java
Stars
593
Forks
123
Avg merge
2d 18h
Merged PRs (30d)
4

Description

## Gentics Mesh Version, operating system, or hardware.
- v0.39.2

The documentation for the Group/Role Filter-Handling for AuthenticationPlugins could be improved a little bit.

It's a little bit confusing, if the group now get removed when the filter returns true or when he return false?

https://github.com/gentics/mesh-plugin-examples/blob/master/authentication-plugin/src/main/java/com/gentics/mesh/plugin/AuthenticationExamplePlugin.java#L68

Maybe handle both cases in the Example Plugin and/or mention that in the configuration

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.