gemini-testing / gemini-testing/testplane

Make better-sqlite3 installation work out of the box

Open
#981 0 comments 0 reactions 0 assignees View on GitHub
backlog
Dominant language
TypeScript
Stars
830
Forks
76
Avg merge
4d 10h
Merged PRs (30d)
14

Description

### Verify latest release

- [X] I verified that the issue exists in the latest Hermione release

### Hermione version

_No response_

### Last Hermione version that worked

_No response_

### Which area(s) of Hermione are affected? (leave empty if unsure)

Hermione core

### Link to the code that reproduces this issue or a replay of the bug

_No response_

### Reproduction steps

When using yarn+pnp (but I suspect it will be the same with npm as well!), when installing testplane you get an error:
```
STDERR gyp ERR! stack TypeError: Cannot assign to read only property 'cflags' of object '#'
```
Additional info:
```
node -v v20.11.1
node-gyp -v v7.1.2
```

The issue here is probably old version of node-gyp, but ideally it should work always regardless of this. Also, we need to make sure that it works in offline environment (without access to github or external internet)

### Actual Behavior

Failed to build better-sqlite3 with node-gyp 7, yarn+pnp

### Expected Behavior

Testplane installation works out of the box

### Which Node.js version are you using?

20.11.1

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.