gemini-testing / gemini-testing/testplane
cannot find invisibleElements typing in
- Dominant language
- TypeScript
- Stars
- 830
- Forks
- 76
- Avg merge
- 4d 10h
- Merged PRs (30d)
- 14
Description
### Verify latest release
- [ ] I verified that the issue exists in the latest Hermione release
### Hermione version
testplane@8.19.6
### Last Hermione version that worked
hermione@8.9.6
### Which area(s) of Hermione are affected? (leave empty if unsure)
_No response_
### Link to the code that reproduces this issue or a replay of the bug
NDA
### Reproduction steps
install testplane with typescript and try
await this.browser.assertView('..., '...', {
...
invisibleElements: ['...'],
});
### Actual Behavior
After migrating from hermione@8 to tesplane faced some problem with typings:
Typescript shows, that invisibleElements is not defined on assertView
```ts
await this.browser.assertView('..., '...', {
invisibleElements: ['...'],
});
```
But tesplane works line invisibleElements are used.
We create patch for typings:
```text
diff --git a/build/src/config/types.d.ts b/build/src/config/types.d.ts
index........ ...
--- a/build/src/config/types.d.ts
+++ b/build/src/config/types.d.ts
@@ -13,6 +13,12 @@ export interface BuildDiffOptsConfig {
ignoreCaret: boolean;
}
export interface AssertViewOptsConfig {
+ /**
+ * DOM-node selectors which will be ignored (painted with a black rectangle) when comparing images.
+ *
+ * @defaultValue `[]`
+ */
+ invisibleElements: string | Array;
/**
* DOM-node selectors which will be ignored (painted with a black rectangle) when comparing images.
*
```
1) Is it really bug in typings ?
2) can you fix this ❤️ ?
### Expected Behavior
No typing error
### Which Node.js version are you using?
20.11.0
Contributor guide
Assessment
This issue has not been assessed yet.