gemini-testing / gemini-testing/testplane

Make 'Unhandled Rejection' error more prominent

Open
#1,007 0 comments 1 reaction 0 assignees View on GitHub
Dominant language
TypeScript
Stars
830
Forks
76
Avg merge
4d 10h
Merged PRs (30d)
14

Description

### Contribution

- [ ] I'd be willing to implement this feature ([contributing guide](https://github.com/gemini-testing/hermione/blob/master/CONTRIBUTING.md))

### Describe the user story

If you forget `await` somewhere you'll probably get the `Unhandled Rejection` and all your tests will be stopped.

At the moment the error looks like:
```
Terminating on critical error: Unhandled Rejection in testplane:worker:2083:
Promise: {}
```
Most of the time it is located in the middle of the test log and it is hard to understand that all of your tests were stopped because of it.

### Describe the solution you'd like

Make the error message more dramatic:
```
————————————————————————————————————
CRITICAL ERROR OCCURED. TERMINATINING ALL TESTS.
Unhandled Rejection in testplane:worker:2083:
Promise: {}
————————————————————————————————————
```

### Describe the drawbacks of your solution

_No response_

### Describe alternatives you've considered

_No response_

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.