geldata / geldata/gel-python

fields with leading underscore

Open
#772 1 comment 0 reactions 1 assignee Claimed by @elprans View on GitHub
Dominant language
Python
Stars
415
Forks
50
PR merge metrics
No merged PRs in 30d

Description

Fields starting with underscore have a special meaning in Pydantic and cannot be supported out of the gate

Things to fix / take care of / ideas:

* Generator should issue a warning when it sees a field with leading underscore or a field that's not valid in Python for some reason
* `GelModel` machinery should mangle the name so that pydantic can have this field at all
* `GelModel` machinery should add an `alias` arg to `FieldInfo` with the original unmangled field name. That will make pydantic accept the original field from input.
* We can also potentially create computeds with demangled names that can write and read from mangled field. Test this.

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.