geldata / geldata/gel-python

Codegen Output Types should always be named after the function

Open
#519 0 comments 0 reactions 0 assignees View on GitHub
Dominant language
Python
Stars
415
Forks
50
PR merge metrics
No merged PRs in 30d

Description

Currently if the output of two generated queries are the same the output type is re-used, though the name seems to fit the first function that used that type.

This leads to problems when changing one of the queries using that output. The output type will change, so imports using it will break.

Since I prefer to typehint most of my applications whenever I change an existing query I have to change unrelated code that used the same output types. The name being unrelated to the query also ends up really awkward at times.

A current example: I have two unrelated models that both have queries that output `{id, name}'. Because I just dropped an output from one of them, they both now use that pattern, so the output is named after the output of another table.

Thanks!

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.