geldata / geldata/gel-python

[Python Suggestion] Linting

Open
#438 1 comment 1 reaction 0 assignees View on GitHub
Dominant language
Python
Stars
415
Forks
50
PR merge metrics
No merged PRs in 30d

Description

Hi there!

I was wondering if there was any interest in general python project related improvements/contributions?

I made a linting proof of concept with [pre-commit](pre-commit.ci), a great tool I use in all my project (even non-Python). I have added a `lint` target in the Makefile to reflect this intention.

https://github.com/adehad/edgedb-python/pull/1/files

There are quite a few things it runs, but I think the autoformatters `black` and `ruff` can be a great asset to run (can even be configured via the pre-commit github action that can autoformat pull requests). `ruff` can be used to swap out `flake8` to run on the generated file too if desired.
Ideally the `mypy` (static type checker) should be run, but looks like there are quite a few errors at the moment.

Happy to help (maybe in smaller increments) if this is something you are considering and/or need help with

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.