geldata / geldata/gel-pkg

Optimize the build time by doing manual docker image builds

Open
#4 4 comments 0 reactions 1 assignee Assigned to @RobertBlumen View on GitHub
Dominant language
Python
Stars
2
Forks
5
PR merge metrics
No merged PRs in 30d

Description

Github [does not support](https://github.community/t5/GitHub-Actions/Expressions-in-Docker-URI/m-p/34067) expressions in the Docker URI, so we explicitly unroll the build matrix into a bunch of steps gated by a conditional expression instead. This works, but the downside is that Github builds *all* docker images in every matrix iteration, effectively building images `n^2` times. All that without using any build cache. The result is that nightly builds easily spend more time in preparing the build images than actually building the packages.

This can be fixed by pre-building all necessary docker images in a separate workflow step, preferably using some sort of build cache (see [actions/cached-docker-build-push](https://github.com/marketplace/actions/cached-docker-build-push)). The build steps would then use pushed images.

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.