geldata / geldata/gel-cli

Maybe display both "plan rows" and "actual rows" in analyze output

Open
#1,143 0 comments 1 reaction 0 assignees View on GitHub
Dominant language
Rust
Stars
175
Forks
32
PR merge metrics
No merged PRs in 30d

Description

Postgres/edgedb reports both "plan_rows" (the number of estimated rows returned by a node in the plan tree) and "actual_rows" (the actual number of rows returned)

It looks like the CLI only displays actual_rows if present, otherwise plan_rows, even in `\expand`d mode. The distinction is not always useful, but it's sometimes important to make sense of confusing behaviors like reported in https://github.com/edgedb/edgedb/issues/5879

It might also be useful to have a displayed hint that `\expand` can be run for more detailed output.
(I don't know if I have ever been satisfied by the non-expanded output.)

Contributor guide

No contributing guide indexed for this repository

Research direction

Start at the CLI's analyze output and compare the normal and \expand modes, focusing on how plan_rows and actual_rows are selected for display. Confirm the desired output with the reported Postgres behavior; done means the row estimates and actual counts are distinguishable and any \expand hint has a clear, tested condition.

Written by the indexing model from the issue text.

Assessment

Tech stack
postgres, rust
Domain
cli
Issue type
Feature
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
42/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.